Uh oh!
There was an error while loading. Please reload this page.
fix database select styling in setup page - #14643
Merged
Merged
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
62 tasks
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
commented
Mar 12, 2019
MemberAuthor
also removes a dangling space |
jancborchardt
commented
Mar 12, 2019
Member
Nice! Can we also get rid of the visible radio circle, so it’s like it was before? The bolding and darker background & text is already sufficient. :) |
skjnldsv
commented
Mar 15, 2019
Member
Done |
skjnldsv
approved these changes
Mar 15, 2019
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 17068: failureTESTS=integration-webdav-related
|
MorrisJobke
commented
Mar 15, 2019
Member
|
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
setup-page-db-select
branch
from
March 15, 2019 14:39
0cf1120 to
4965f8cCompareskjnldsv
commented
Mar 15, 2019
Member
Done @MorrisJobke |
MorrisJobke
commented
Mar 15, 2019
Member
Shouldn't it be bold? But I'm fine with both ways 👍 |
rullzer
commented
Mar 15, 2019
Member
Lets do this. If it needs to be bold we fix it later. @jancborchardt |
MorrisJobke
commented
Mar 15, 2019
Member
I talked with Jan about it and non-bold is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.