Skip to content

always allow moving mountpoints inside the same mountpoint - #14691

Merged
rullzer merged 1 commit into
masterfrom
rename-mountpoint-within-mountpoint
Mar 20, 2019
Merged

always allow moving mountpoints inside the same mountpoint#14691
rullzer merged 1 commit into
masterfrom
rename-mountpoint-within-mountpoint

Conversation

@icewind1991

@icewind1991icewind1991 commented Mar 14, 2019•
edited by MorrisJobke
Loading

Copy link
Copy Markdown
Member

even if that mountpoint isn't normally a valid target for moving mounts into

Fixes#13451

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Mar 14, 2019
@icewind1991icewind1991 added this to the Nextcloud 16 milestone Mar 14, 2019
@icewind1991

icewind1991 commented Mar 14, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@icewind1991

icewind1991 commented Mar 14, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable14

@icewind1991

icewind1991 commented Mar 14, 2019

Copy link
Copy Markdown
MemberAuthor

Fixes #13451

MorrisJobke
MorrisJobke approved these changes Mar 14, 2019
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

rullzer
rullzer approved these changes Mar 14, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🐘

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@MorrisJobkeMorrisJobke mentioned this pull request Mar 14, 2019
Merged
@MorrisJobkeMorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Mar 14, 2019
@icewind1991
always allow moving mountpoints inside the same mountpoint
cc29f5d
even if that mountpoint isn't normally a valid target for moving mounts into
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the rename-mountpoint-within-mountpoint branch from 99c81e9 to cc29f5dCompareMarch 19, 2019 14:56
@MorrisJobkeMorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
@nextcloudnextcloud deleted a comment from faily-botBotMar 20, 2019
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Mar 20, 2019
MorrisJobke
MorrisJobke approved these changes Mar 20, 2019
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested and still works 👍

@rullzer
rullzer merged commit 6458dd8 into masterMar 20, 2019
@rullzer
rullzer deleted the rename-mountpoint-within-mountpoint branch March 20, 2019 09:58
@MorrisJobke

MorrisJobke commented Mar 20, 2019

Copy link
Copy Markdown
Member

/backport to stable15

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Mar 20, 2019
Merged
@MorrisJobke

MorrisJobke commented Mar 20, 2019

Copy link
Copy Markdown
Member

/backport to stable14

@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 20, 2019

Copy link
Copy Markdown

backport to stable15 in #14759

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Mar 20, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 20, 2019

Copy link
Copy Markdown

backport to stable14 in #14760

@MorrisJobkeMorrisJobke mentioned this pull request Mar 25, 2019
Closed
@nickvergessennickvergessen mentioned this pull request Mar 25, 2019
Merged
@MorrisJobkeMorrisJobke mentioned this pull request Mar 25, 2019
Closed
@skjnldsvskjnldsv mentioned this pull request Jun 14, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@MorrisJobke@rullzer