Skip to content

Show sharing in menu in grid view - #14695

Merged
MorrisJobke merged 3 commits into
masterfrom
enhancement/grid/sharing-in-menu
Mar 21, 2019
Merged

Show sharing in menu in grid view#14695
MorrisJobke merged 3 commits into
masterfrom
enhancement/grid/sharing-in-menu

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Mar 14, 2019

Copy link
Copy Markdown
Member

Capture d’écran_2019-03-14_17-57-11
Capture d’écran_2019-03-14_17-57-20
Capture d’écran_2019-03-14_17-57-32

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

@skjnldsvskjnldsv added this to the Nextcloud 16 milestone Mar 14, 2019
@skjnldsvskjnldsv self-assigned this Mar 14, 2019
juliusknorr
juliusknorr reviewed Mar 14, 2019
View reviewed changes
Comment threadapps/files/js/fileactionsmenu.js Outdated
juliusknorr
juliusknorr reviewed Mar 14, 2019
View reviewed changes
Comment threadapps/files/js/fileactionsmenu.js Outdated
@skjnldsv
skjnldsvforce-pushed the enhancement/grid/sharing-in-menu branch from 20018ab to 615c069CompareMarch 14, 2019 17:59
@jancborchardt

jancborchardt commented Mar 15, 2019

Copy link
Copy Markdown
Member

Was just comparing with the right-click menu and also with our logical sorting – and I have to correct myself: Let’s put the "Share" action first in the list, above "Favorites" rather than below. Since elsewhere it’s always the first action, even being outside of the menu. :)

Otherwise awesome! 🎉

jancborchardt
jancborchardt requested changes Mar 15, 2019
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said let’s put Share as first entry in the menu (sorry for the confusion) then it’s 👍 :)

@skjnldsv

skjnldsv commented Mar 15, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

As said let’s put Share as first entry in the menu (sorry for the confusion) then it’s :)

Above favorite? just read the message above! :)
👌

@skjnldsv

skjnldsv commented Mar 15, 2019

Copy link
Copy Markdown
MemberAuthor

@jancborchardt done! 😉

@MorrisJobke

MorrisJobke commented Mar 15, 2019

Copy link
Copy Markdown
Member

It now only shows "Shared" for me with the normal share icon instead of the little chain for public links or the avatar for user/group shares. 😢

@skjnldsv

skjnldsv commented Mar 15, 2019

Copy link
Copy Markdown
MemberAuthor

It now only shows "Shared" for me with the normal share icon instead of the little chain for public links

I guess I missed some check :)

or the avatar for user/group shares.

But this is only on incoming shares, right?

@MorrisJobke

MorrisJobke commented Mar 15, 2019

Copy link
Copy Markdown
Member

But this is only on incoming shares, right?

Ah - right.

jancborchardt
jancborchardt approved these changes Mar 15, 2019
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@skjnldsvskjnldsv mentioned this pull request Mar 16, 2019
Merged
@MorrisJobkeMorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 19, 2019
@MorrisJobkeMorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
@MorrisJobke

MorrisJobke commented Mar 20, 2019

Copy link
Copy Markdown
Member

@skjnldsv Mind to fix the unit tests and conflicts?

@skjnldsv

skjnldsv commented Mar 20, 2019

Copy link
Copy Markdown
MemberAuthor

@skjnldsv in my todo for today :)

@skjnldsvskjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 21, 2019
@skjnldsv

skjnldsv commented Mar 21, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Fixed, rebased and ready to go 🚀

@skjnldsv
Show sharing in menu in grid view
4ad922d
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Put sharing entry all above
4c884f1
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Add link icon for public link too
ff164db
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the enhancement/grid/sharing-in-menu branch from 17ec4c1 to ff164dbCompareMarch 21, 2019 07:16
MorrisJobke
MorrisJobke approved these changes Mar 21, 2019
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 21, 2019
@faily-bot

faily-botBot commented Mar 21, 2019

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17201: failure

TESTS=ui-regression

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

@MorrisJobke
MorrisJobke merged commit 2389b61 into masterMar 21, 2019
@MorrisJobke
MorrisJobke deleted the enhancement/grid/sharing-in-menu branch March 21, 2019 08:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@jancborchardtjancborchardtjancborchardt approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugdesignDesign, UI, UX, etc.feature: filesfeature: sharing

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@jancborchardt@MorrisJobke@juliusknorr