Skip to content

Deprecate marked, escapeHTML, formatDate, getURLParameter, humanFileS… - #14705

Merged
rullzer merged 1 commit into
masterfrom
deprecate/marked-escapeHTML-formatDate-getURLParameter-humanFileSize-relative_modified_date-select2
Mar 15, 2019
Merged

Deprecate marked, escapeHTML, formatDate, getURLParameter, humanFileS…#14705
rullzer merged 1 commit into
masterfrom
deprecate/marked-escapeHTML-formatDate-getURLParameter-humanFileSize-relative_modified_date-select2

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Mar 14, 2019

Copy link
Copy Markdown
Member

…ize, relative_modified_date and select2

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

@skjnldsvskjnldsv added the 3. to review Waiting for reviews label Mar 14, 2019
@skjnldsvskjnldsv added this to the Nextcloud 16 milestone Mar 14, 2019
@skjnldsvskjnldsv self-assigned this Mar 14, 2019
ChristophWurst
ChristophWurst approved these changes Mar 14, 2019
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@MorrisJobke

MorrisJobke commented Mar 14, 2019

Copy link
Copy Markdown
Member

Would be nice to also print which method to use instead then.

@faily-bot

faily-botBot commented Mar 15, 2019

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17046: failure

TESTS=ui-regression

@MorrisJobke

MorrisJobke commented Mar 15, 2019

Copy link
Copy Markdown
Member

Conflicts 🙈

@skjnldsv@rullzer
Deprecate marked, escapeHTML, formatDate, getURLParameter, humanFileS…
b4dd12e
…ize, relative_modified_date and select2
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@rullzer
rullzerforce-pushed the deprecate/marked-escapeHTML-formatDate-getURLParameter-humanFileSize-relative_modified_date-select2 branch from f3e03e3 to b4dd12eCompareMarch 15, 2019 15:40
@rullzer
rullzer merged commit f429098 into masterMar 15, 2019
@rullzer
rullzer deleted the deprecate/marked-escapeHTML-formatDate-getURLParameter-humanFileSize-relative_modified_date-select2 branch March 15, 2019 17:08
@MorrisJobkeMorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
@danxuliu

danxuliu commented Aug 19, 2019

Copy link
Copy Markdown
Member

Would be nice to also print which method to use instead then.

Even if it is not printed it would be good to at least have it documented in this pull request (just in case someone else besides me ends here when checking the commit history ;-) ); @skjnldsv could you mention which functions should be used instead? Thanks :-)

@ChristophWurst

ChristophWurst commented Aug 26, 2019

Copy link
Copy Markdown
Member

I think there was an existing npm package that does exactly what our function did. @skjnldsv what was its name?

@skjnldsv

skjnldsv commented Aug 26, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@ChristophWurst for the escapeHtml?
https://www.npmjs.com/package/escape-html

@ChristophWurst

ChristophWurst commented Aug 26, 2019

Copy link
Copy Markdown
Member

Published 4 years ago

@skjnldsv

skjnldsv commented Aug 26, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Well, it's such a simple library I don't really see what you can do more to upgrade it xD

Still maintained https://github.com/component/escape-html

@ChristophWurst

ChristophWurst commented Aug 26, 2019

Copy link
Copy Markdown
Member

oh, lol, yes https://github.com/component/escape-html/blob/master/index.js#L33-L78 😆

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv@MorrisJobke@danxuliu@ChristophWurst@rullzer