Skip to content

CSP: set nonce for iframes - #14724

Merged
MorrisJobke merged 1 commit into
masterfrom
enh/nonce_for_iframes
Mar 18, 2019
Merged

CSP: set nonce for iframes#14724
MorrisJobke merged 1 commit into
masterfrom
enh/nonce_for_iframes

Conversation

@rullzer

Copy link
Copy Markdown
Member

This for now uses the jsNonce. That way we can easily backport it.
For 17 I will fix it properly.

This for now uses the jsNonce. That way we can easily backport it.
For 17 I will fix it properly.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@faily-bot

faily-botBot commented Mar 16, 2019

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17097: failure

TESTS=ui-regression

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke
MorrisJobke merged commit 4583595 into masterMar 18, 2019
@MorrisJobke
MorrisJobke deleted the enh/nonce_for_iframes branch March 18, 2019 15:17
@MorrisJobkeMorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@nickvergessen@MorrisJobke