Skip to content

Improve startup speed of acceptance tests - #14737

Merged
rullzer merged 1 commit into
masterfrom
improve-starting-speed-of-acceptance-tests
Mar 18, 2019
Merged

Improve startup speed of acceptance tests#14737
rullzer merged 1 commit into
masterfrom
improve-starting-speed-of-acceptance-tests

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Actual change is to add --exclude="node_modules"
Then I added line breaks for readability and better adding new entries locally.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added bug 3. to review Waiting for reviews labels Mar 18, 2019
@nickvergessennickvergessen added this to the Nextcloud 16 milestone Mar 18, 2019

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense 👍

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is happy I'm fine

@rullzer
rullzer merged commit 8c04972 into masterMar 18, 2019
@rullzer
rullzer deleted the improve-starting-speed-of-acceptance-tests branch March 18, 2019 15:21
@MorrisJobkeMorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@rullzer@MorrisJobke