Uh oh!
There was an error while loading. Please reload this page.
Use max contrast variable to cap the generated colours - #14776
Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
MorrisJobke, jancborchardt, juliusknorr and rullzerMarch 21, 2019 07:47
ChristophWurst
approved these changes
Mar 21, 2019
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Code could be improved, but makes sense 👍
| // ensure that the brightest color is still readable | ||
| // min. color contrast for normal text on white background according to WCAG AA | ||
| if (sizeColor >= maxContrast) { |
There was a problem hiding this comment.
You can use Math.min and Math.max to your advantage
x = Math.max(min, Math.min(max, x))
Member
There was a problem hiding this comment.
Let's do this in a follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
@nextcloud/designers