Skip to content

Fix user creation using LDAP Plugin - #14778

Merged
MorrisJobke merged 3 commits into
masterfrom
user_ldap_createuser_fix
Mar 21, 2019
Merged

Fix user creation using LDAP Plugin#14778
MorrisJobke merged 3 commits into
masterfrom
user_ldap_createuser_fix

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Same as #12452 but rebased on master.

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
This commit fix an error happening when the subadmin tries to create an
user, adding him/her to the group s/he is subadmin of, using a LDAP
User/Group plugin.
This just forces the cache to be reset after an user is added to a
group.
Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
LDAP plugins must change the createUser method to return the DN, as we
need this to update the cache.
Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Mar 21, 2019
@MorrisJobkeMorrisJobke added this to the Nextcloud 16 milestone Mar 21, 2019
@MorrisJobke
MorrisJobke requested a review from blizzzMarch 21, 2019 09:22
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

/backport to stable14

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Reviews for this are in #12452

@MorrisJobke
MorrisJobke merged commit 0155edc into masterMar 21, 2019
@MorrisJobke
MorrisJobke deleted the user_ldap_createuser_fix branch March 21, 2019 10:32
@MorrisJobkeMorrisJobke mentioned this pull request Mar 21, 2019
9 tasks
@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #14781

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable14 in #14782

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: ldap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@MorrisJobke@viniciuscb