Uh oh!
There was an error while loading. Please reload this page.
Fetch proper translations - #14801
Merged
Merged
Conversation
rullzer
requested review from
ChristophWurst, MorrisJobke, juliusknorr and nickvergessenMarch 22, 2019 08:49
ChristophWurst
approved these changes
Mar 22, 2019
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Makes sense
Test might break, but @MorrisJobke's bot will tell us :)
nickvergessen
approved these changes
Mar 22, 2019
Fixes#14793 This is caused by the mess we have with OC\Settings mapping to settings and lib/private/Settings. Anyway this is the quick fix. Moving stuff around for 17 seems better. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
fix/14793/fetch_right_translations
branch
from
March 25, 2019 08:11
7b99c9d to
a7fb71fCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#14793
This is caused by the mess we have with OC\Settings mapping to settings
and lib/private/Settings.
Anyway this is the quick fix. Moving stuff around for 17 seems better.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl