Skip to content

Fix filepicker's add button design - #14806

Merged
MorrisJobke merged 1 commit into
masterfrom
fix/files/picker-new-button
Mar 25, 2019
Merged

Fix filepicker's add button design#14806
MorrisJobke merged 1 commit into
masterfrom
fix/files/picker-new-button

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Mar 22, 2019

Copy link
Copy Markdown
Member

@nextcloud/designers

BeforeAfter
Capture d’écran_2019-03-22_10-36-45Capture d’écran_2019-03-22_10-36-36

@skjnldsvskjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: filepicker labels Mar 22, 2019
@skjnldsvskjnldsv added this to the Nextcloud 16 milestone Mar 22, 2019
@skjnldsvskjnldsv self-assigned this Mar 22, 2019
@ChristophWurst

ChristophWurst commented Mar 22, 2019•
edited by skjnldsv
Loading

Copy link
Copy Markdown
Member
  • BUG the popover is slightly misplaced

Bildschirmfoto von 2019-03-22 10-41-24

@skjnldsv
Fix filepicker's add button design
3736bc8
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the fix/files/picker-new-button branch from f95c70a to 3736bc8CompareMarch 22, 2019 10:09
@MorrisJobke

MorrisJobke commented Mar 22, 2019

Copy link
Copy Markdown
Member
  • bug: clicking the "->" results in ReferenceError: Can't find variable: Files

Bildschirmfoto 2019-03-22 um 11 45 28

@MorrisJobke

MorrisJobke commented Mar 22, 2019

Copy link
Copy Markdown
Member

Why is there the add button at all? In 15 there was no such button. Couldn't it be removed?

@ChristophWurst

ChristophWurst commented Mar 22, 2019

Copy link
Copy Markdown
Member

Why is there the add button at all? In 15 there was no such button. Couldn't it be removed?

I was wondering as well. I guess we need it for copy and move. When you literally pick a file it doesn't make sense to have this button.

@skjnldsv

skjnldsv commented Mar 22, 2019

Copy link
Copy Markdown
MemberAuthor

I have no idea X)

@MorrisJobke

MorrisJobke commented Mar 25, 2019

Copy link
Copy Markdown
Member

Could this PR hides the button, so that it works like before?

@skjnldsv

This comment has been minimized.

Sign in to view
@skjnldsv

skjnldsv commented Mar 25, 2019

Copy link
Copy Markdown
MemberAuthor

Ah nope! This was a feature: #13177
Approved by Jan!

@ChristophWurst

ChristophWurst commented Mar 25, 2019

Copy link
Copy Markdown
Member

Approved by Jan!

🙈 🙊 🙉

@MorrisJobke

MorrisJobke commented Mar 25, 2019

Copy link
Copy Markdown
Member

#14806 (comment) <- this is still broken 😉 (on the personal settings page)

@ChristophWurst

ChristophWurst commented Mar 25, 2019

Copy link
Copy Markdown
Member

cc'ing the original author @rummatee for help

@MorrisJobke

MorrisJobke commented Mar 25, 2019

Copy link
Copy Markdown
Member

#14806 (comment) <- this is still broken 😉 (on the personal settings page)

Anyway - was broken before as well -> let's merge this first fix.

@MorrisJobke
MorrisJobke merged commit 4a1cf54 into masterMar 25, 2019
@MorrisJobke
MorrisJobke deleted the fix/files/picker-new-button branch March 25, 2019 12:56
@MorrisJobke

MorrisJobke commented Mar 25, 2019

Copy link
Copy Markdown
Member

Extracted issue to #14834

@rullzerrullzer mentioned this pull request Mar 26, 2019
Merged
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.feature: filepicker

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@ChristophWurst@MorrisJobke