Skip to content

Force boolean type for access parameter - #14812

Merged
rullzer merged 1 commit into
masterfrom
bugfix/noid/collections-access-type
Mar 23, 2019
Merged

Force boolean type for access parameter#14812
rullzer merged 1 commit into
masterfrom
bugfix/noid/collections-access-type

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

Otherwise the sql query fails if the resource provider returns null for access.

Signed-off-by: Julius Härtl <jus@bitgrid.net>

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rullzerrullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 22, 2019
@faily-bot

faily-botBot commented Mar 22, 2019

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17254: failure

TESTS=acceptance, TESTS-ACCEPTANCE=login

  • tests/acceptance/features/login.feature:38
Show full log
 Scenario: log in with invalid user once fixed by admin # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:38
Given I act as John # ActorContext::iActAs()
And I can not log in with user unknownUser and password 123456acb # LoginPageContext::iCanNotLogInWithUserAndPassword()
When I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
New user button in Users Settings could not be found (NoSuchElementException)
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I create user unknownUser with password 123456acb # UsersSettingsContext::iCreateUserWithPassword()
And I see that the list of users contains the user unknownUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I act as John # ActorContext::iActAs()
And I log in with user unknownUser and password 123456acb # LoginPageContext::iLogInWithUserAndPassword()

@rullzer
rullzer merged commit b04bdad into masterMar 23, 2019
@rullzer
rullzer deleted the bugfix/noid/collections-access-type branch March 23, 2019 11:33
@rullzerrullzer mentioned this pull request Mar 26, 2019
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@rullzer@nickvergessen@ChristophWurst