Skip to content

hide new folder button in choose type filepicker - #14900

Merged
MorrisJobke merged 1 commit into
nextcloud:masterfrom
rummatee:issue14834
Apr 1, 2019
Merged

hide new folder button in choose type filepicker#14900
MorrisJobke merged 1 commit into
nextcloud:masterfrom
rummatee:issue14834

Conversation

@rummatee

Copy link
Copy Markdown
Contributor

This pull requests aims to solve issue #14834
It hides the button to create a new folder in the filepicker if the type is choose.
I think that in this case it wouldn't make sense to create a new folder anyway.

Please review @MorrisJobke@jancborchardt @nextcloud/designers

@skjnldsv

skjnldsv commented Mar 28, 2019

Copy link
Copy Markdown
Member

Hello @rummatee
Sorry, but this is a feature and should not be removed.
We need to fix the error instead.
See #13177 :)

@rummatee

Copy link
Copy Markdown
ContributorAuthor

For the original pull request that introduced this feature, I had only the situation in mind where a file is moved. I also understand the original issue from @MariusBluem and @jancborchardt this way.
I didn't think about the fact, that the same filepicker dialog is also used for choosing a file (even though the name makes this pretty obvious 🙈 )
I think that in the case of choosing a file, it doesn't make sense to create a new folder (at least as long as it isn't possible to move a file there, too) and this pull request only removes the button in this case.
Leaving this button outside of the files app would require an alternative way to check if a name for the new folder is valid.

@skjnldsv

Copy link
Copy Markdown
Member

@rummatee my apologise, I thought someone else created the original pull request.
We're in beta2, so I think you're right, we should get this in!! 🚀

Sorry for the misunderstanding! I should have read better ! 🙇‍♀️

Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
@rullzerrullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 29, 2019
@MorrisJobke
MorrisJobke merged commit a131999 into nextcloud:masterApr 1, 2019
@MorrisJobkeMorrisJobke mentioned this pull request Apr 3, 2019
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@rummatee@skjnldsv@juliusknorr@kesselb@rullzer@MorrisJobke