Skip to content

Skip check if CONSTANT on real object is used - #14925

Merged
rullzer merged 1 commit into
masterfrom
bugfix/14824-skip-check
Apr 2, 2019
Merged

Skip check if CONSTANT on real object is used#14925
rullzer merged 1 commit into
masterfrom
bugfix/14824-skip-check

Conversation

@kesselb

Copy link
Copy Markdown
Contributor

Close#14824

Not really a fix. We just skip the check in case.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to do for now I guess.
Could you craete an issue to properly fix this?

@rullzer
rullzer merged commit cffa71a into masterApr 2, 2019
@rullzer
rullzer deleted the bugfix/14824-skip-check branch April 2, 2019 20:55
@MorrisJobkeMorrisJobke mentioned this pull request Apr 3, 2019
2 tasks
@kesselbkesselb self-assigned this Apr 4, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NC 16] $this->property::CONSTANT breaks app:check-code command

3 participants

@kesselb@rullzer@MorrisJobke