Uh oh!
There was an error while loading. Please reload this page.
Show comments and restore in popover menu - #14931
Merged
Merged
Conversation
skjnldsv
commented
Apr 2, 2019
Member
| 0 | 1 | 2 |
|---|---|---|
 |  |  |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
ChristophWurst, MorrisJobke, jancborchardt, juliusknorr and rullzerApril 2, 2019 10:26
62 tasks
jancborchardt
commented
Apr 2, 2019
Member
Looks nice! Do we want to just say "1 comment" without the "new"? (Will probably be worse in other translations.) |
skjnldsv
commented
Apr 2, 2019
MemberAuthor
I agree, but then it would not really be appropriate if you think about the real comments count? 🤔 |
ChristophWurst
approved these changes
Apr 2, 2019
skjnldsv
commented
Apr 2, 2019
MemberAuthor
@jancborchardt so what do we do in the end? |
jancborchardt
commented
Apr 2, 2019
Member
Hm, then let's just go for it like it is in the PR now. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.