Skip to content

Fix mobile menu on users management - #14934

Merged
skjnldsv merged 1 commit into
masterfrom
fix/settings/hamburger-menu
Apr 2, 2019
Merged

Fix mobile menu on users management#14934
skjnldsv merged 1 commit into
masterfrom
fix/settings/hamburger-menu

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Apr 2, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@skjnldsvskjnldsv added this to the Nextcloud 16 milestone Apr 2, 2019
@skjnldsvskjnldsv self-assigned this Apr 2, 2019
@skjnldsvskjnldsv mentioned this pull request Apr 2, 2019
Closed
@MorrisJobke

MorrisJobke commented Apr 2, 2019

Copy link
Copy Markdown
Member

Doesn't work for me somehow 🤷‍♂️ It simply does not show up even after cleaned browser caches.

ChristophWurst
ChristophWurst approved these changes Apr 2, 2019
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on FF

@MorrisJobke

MorrisJobke commented Apr 2, 2019

Copy link
Copy Markdown
Member

Not here (tested with FF and Safari - ignore the failing avatar - there the PHP build-in server crashes, but only for this request):

Bildschirmfoto 2019-04-02 um 16 22 53

rullzer
rullzer approved these changes Apr 2, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me as well.
Lets ignore @MorrisJobke

@rullzer

rullzer commented Apr 2, 2019

Copy link
Copy Markdown
Member

But conflicts!

@skjnldsv@rullzer
Fix mobile menu on users management
6bfd77d
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@rullzer
rullzerforce-pushed the fix/settings/hamburger-menu branch from 63bf550 to 6bfd77dCompareApril 2, 2019 17:43
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 2, 2019
@skjnldsv
skjnldsv merged commit 2a5742d into masterApr 2, 2019
@skjnldsv
skjnldsv deleted the fix/settings/hamburger-menu branch April 2, 2019 18:47
@MorrisJobkeMorrisJobke mentioned this pull request Apr 3, 2019
Merged
2 tasks
@Octopus2

Octopus2 commented May 13, 2019

Copy link
Copy Markdown

I am on 16 RC1 and this fix doesn´t work for me on my android device (Galaxy S7, Android 8, Chrome)....

@skjnldsv

skjnldsv commented May 13, 2019

Copy link
Copy Markdown
MemberAuthor

@Octopus2 make sure to clear your cache :)

@Octopus2

Octopus2 commented May 13, 2019•
edited
Loading

Copy link
Copy Markdown

@skjnldsv I cleaned the Chrome-Cache and it still doesn´t work.
Just tried it with Firefox on Windows 7 and same behavior when i resize the browserwindow. No menu/Burger on the left in user- and appmanagement....
Even tried this but nothing changes: #10436 (comment)

Anything else I can do to test?

@Octopus2

Octopus2 commented May 14, 2019

Copy link
Copy Markdown

sorry, correct is for my setup with this problem: 16.0.1 RC 1

@skjnldsvskjnldsv mentioned this pull request Jun 7, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugregression

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

Missing hamburger menu in mobile mode

5 participants

@skjnldsv@MorrisJobke@rullzer@Octopus2@ChristophWurst