Skip to content

Adjust drone config to drone 1.0.0 - #14958

Merged
MorrisJobke merged 1 commit into
masterfrom
fix-drone
Apr 4, 2019
Merged

Adjust drone config to drone 1.0.0#14958
MorrisJobke merged 1 commit into
masterfrom
fix-drone

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

No description provided.

@kesselb

Copy link
Copy Markdown
Contributor

Drone 1.0 👏 Is it possible to stop my own ci builds now?

@kesselb

Copy link
Copy Markdown
Contributor

Peek 2019-04-04 15-15

I can create and delete secret variables. I have not tested to remove GITHUB_TOKEN

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Yep - looking into it :/ they changed all the names of their configs and missing the one for admins :(

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor
  • handlebars looks weird:
1 | npm install handlebars -g
2 | /usr/local/bin/handlebars -> /usr/local/lib/node_modules/handlebars/bin/handlebars
3 | + handlebars@4.1.1
4 | added 8 packages from 40 contributors in 0.597s
5 | + ./build/compile-handlebars-templates.sh
6 | 7 | /usr/local/lib/node_modules/handlebars/bin/handlebars:120
8 | throw err;
9 | ^
10 | Error: Unable to open template file "apps/comments/js/templates"
11 | at /usr/local/lib/node_modules/handlebars/dist/cjs/precompiler.js:103:25
12 | at FSReqCallback.oncomplete (fs.js:158:21)
13 | 14 | /usr/local/lib/node_modules/handlebars/bin/handlebars:120
15 | throw err;
16 | ^
17 | Error: Unable to open template file "apps/files_versions/js/templates"
18 | at /usr/local/lib/node_modules/handlebars/dist/cjs/precompiler.js:103:25
19 | at FSReqCallback.oncomplete (fs.js:158:21)
20 | All up to date! Carry on :D

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

[ ] handlebars looks weird:

Also on master - I have a change locally but will do this in a separate PR.

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

I can create and delete secret variables. I have not tested to remove GITHUB_TOKEN

Seems to be because you are a member of the org. Acceptable - if somebody goes wild we readd the secret and then maybe block the user.

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Apr 4, 2019
@MorrisJobkeMorrisJobke added this to the Nextcloud 16 milestone Apr 4, 2019
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Drone 1.0 👏 Is it possible to stop my own ci builds now?

It should be - also all others ;)

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Ready to merge - some of the jobs ran into the timeout of 30 minutes, but the general config is working.

@MorrisJobke
MorrisJobke merged commit 952cb3f into masterApr 4, 2019
@MorrisJobke
MorrisJobke deleted the fix-drone branch April 4, 2019 23:24
@rullzerrullzer mentioned this pull request Apr 10, 2019
13 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@kesselb@rullzer