Skip to content

Prevent a reinstall - #14965

Merged
MorrisJobke merged 1 commit into
masterfrom
enh/install_file
Apr 11, 2019
Merged

Prevent a reinstall#14965
MorrisJobke merged 1 commit into
masterfrom
enh/install_file

Conversation

@rullzer

@rullzerrullzer commented Apr 4, 2019•
edited
Loading

Copy link
Copy Markdown
Member

No description provided.

@rullzerrullzer added this to the Nextcloud 16 milestone Apr 4, 2019
nickvergessen
nickvergessen reviewed Apr 5, 2019
View reviewed changes
Comment threadcore/templates/installation_forbidden.php Outdated
@MorrisJobke

MorrisJobke commented Apr 5, 2019

Copy link
Copy Markdown
Member

[ ] Maybe a check in the admin settings?

for what? if the file is present? but the updater should remove it, right?

@nickvergessen

nickvergessen commented Apr 5, 2019

Copy link
Copy Markdown
Member

I vote for a bypass on update channel git.
Otherwise this will be a pain for developers.

You always remove the file and commit it by accident and you need to recreate it, in order to be able to reinstall

@rullzer

rullzer commented Apr 5, 2019

Copy link
Copy Markdown
MemberAuthor

I vote for a bypass on update channel git.
Otherwise this will be a pain for developers.

You always remove the file and commit it by accident and you need to recreate it, in order to be able to reinstall

yes that was also my idea 👍

@rullzer

rullzer commented Apr 8, 2019

Copy link
Copy Markdown
MemberAuthor

Done I think

@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 9, 2019
@rullzerrullzer mentioned this pull request Apr 10, 2019
Merged
13 tasks
ChristophWurst
ChristophWurst reviewed Apr 10, 2019
View reviewed changes
Comment threadcore/Controller/SetupController.php Outdated
Comment threadlib/private/Updater.php Outdated
Comment threadlib/private/Updater.php Outdated
@rullzer
Block install without CAN_INSTALL file
7e7146d
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 11, 2019
@MorrisJobke
MorrisJobke merged commit ef06c3f into masterApr 11, 2019
@MorrisJobke
MorrisJobke deleted the enh/install_file branch April 11, 2019 08:19
@rullzer

rullzer commented Apr 15, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 15, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 15, 2019

Copy link
Copy Markdown

backport to stable15 in #15112

@nickvergessen

nickvergessen commented Apr 15, 2019

Copy link
Copy Markdown
Member

Was merged before stable16 right?

@ChristophWurst

ChristophWurst commented Apr 15, 2019

Copy link
Copy Markdown
Member

Yes: https://github.com/nextcloud/server/blob/stable16/config/CAN_INSTALL

@GuyPaddockGuyPaddock mentioned this pull request Feb 25, 2022
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@blizzzblizzzAwaiting requested review from blizzz
@schiessleschiessleAwaiting requested review from schiessle

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancement

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@MorrisJobke@nickvergessen@ChristophWurst