Uh oh!
There was an error while loading. Please reload this page.
Add repair step and revert "Open updater" button - #1499
Merged
Conversation
This reverts commit 202ae42. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
mention-bot
commented
Sep 23, 2016
@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @LukasReschke and @blizzz to be potential reviewers |
karlitschek
commented
Sep 23, 2016
Member
nice 👍 As discussed! |
This was referenced Sep 23, 2016
MorrisJobkeforce-pushed
the
updater
branch
2 times, most recently
from
September 24, 2016 09:18
479cb77 to
9130d3aCompareMorrisJobke
commented
Sep 24, 2016
MemberAuthor
needed to rebase to fix the sign-off message in the commits ;) |
| 'updateLink' => 'https://docs.nextcloud.com/myUrl', | ||
| 'downloadLink' => 'https://downloads.nextcloud.org/server', | ||
| 'updateVersion' => 'ownCloud 123', | ||
| 'updateLink' => 'https://owncloud.org/myUrl', |
There was a problem hiding this comment.
Id not revert all in this, when possible
MemberAuthor
There was a problem hiding this comment.
True story. I will fix it.
nickvergessen
commented
Sep 26, 2016
Member
Looks good otherwise |
This reverts commit 27a3c68. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
commented
Sep 26, 2016
MemberAuthor
I added the wrongly removed tests here. |
LukasReschke
commented
Sep 26, 2016
Member
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data/updater-INSTANCEID/.stepto a file named.step-previous-updateto not show all steps as done on the next updatecc @LukasReschke@nickvergessen@karlitschek
I will open the PRs for stable9 and stable10 soon