Uh oh!
There was an error while loading. Please reload this page.
Remove negation for swift tmp file - #15010
Conversation
Signed-off-by: Michael Zamot <michael@zamot.io>
icewind1991
commented
Apr 9, 2019
Removing the negation here is incorrect, since it would then read use the logic for non-seekable streams for streams that are seekable and not for streams that aren't. The issue here is that streams which are seekable do not upload correctly, that either needs to be resolved or the entire check needs to be removed and we always need to do the fallback code |
schoenpat
commented
Apr 16, 2019
@icewind1991 |
kesselb
commented
Apr 16, 2019
@schoenpat this would be an acceptable "fix". changing the condition like suggested is wrong. should be easy to change this pr like suggested @mzamot 🏓 |
rullzer
commented
Apr 18, 2019
I remove the entire check in #15168. |
After testing PR #14570 in NC15 and Master, I couldn't write files bigger than 10MB with the negation on the verification. After removing the negation it worked just fine.
See issue #13554