Uh oh!
There was an error while loading. Please reload this page.
Forbid eval on legacy responses - #15016
Merged
Merged
Conversation
rullzer
requested review from
ChristophWurst, MorrisJobke, juliusknorr and nickvergessenApril 9, 2019 07:48
ChristophWurst
approved these changes
Apr 9, 2019
nickvergessen
approved these changes
Apr 9, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rullzerforce-pushed
the
enh/no-eval-default-response
branch
from
April 9, 2019 07:56
c1f323e to
3b1e164Comparenickvergessen
approved these changes
Apr 9, 2019
ChristophWurst
approved these changes
Apr 9, 2019
nickvergessen
approved these changes
Apr 9, 2019
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
skjnldsv
approved these changes
Apr 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems I missed this one.
We do not use this response type a lot anymore. But should fix it still.