Uh oh!
There was an error while loading. Please reload this page.
Do not allow JavaScript "eval" in the public share auth page with Talk - #15049
Merged
MorrisJobke merged 1 commit intoApr 11, 2019
Conversation
Talk no longer uses JavaScript "eval", so the Content Security Policy can now be configured to prevent its use in the public share authentication page when the password is protected by Talk. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
MorrisJobke
approved these changes
Apr 11, 2019
MorrisJobke
deleted the
do-not-allow-javascript-eval-in-the-public-share-auth-page-with-talk
branch
April 11, 2019 07:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Talk no longer uses JavaScript
eval(well, right now it still does, but it will not once the linked pull request is merged), so the Content Security Policy can now be configured to prevent its use in the public share authentication page when the password is protected by Talk.