Skip to content

Check if the data is in the lookup server - #15122

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/check-undefined-index
May 2, 2019
Merged

Check if the data is in the lookup server#15122
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/check-undefined-index

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Related log entry: Undefined index: email at /var/www/settings/BackgroundJobs/VerifyUserData.php#213

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable14

@kesselb

Copy link
Copy Markdown
Contributor

Is it correct to return false in this case? Is it possible that the information is available if you retry later?

@ChristophWurst

Copy link
Copy Markdown
Member

Is it correct to return false in this case? Is it possible that the information is available if you retry later?

This is exactly what the method should return as per doc block. it can't check the verification right now ;)

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Reviews please

@MorrisJobke
MorrisJobke merged commit f20de92 into masterMay 2, 2019
@MorrisJobke
MorrisJobke deleted the bugfix/noid/check-undefined-index branch May 2, 2019 09:58
@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable16 in #15341

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #15342

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable14 in #15343

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@kesselb@ChristophWurst@MorrisJobke