Uh oh!
There was an error while loading. Please reload this page.
Enh/share repair step - #15129
Merged
Merged
Conversation
rullzer
requested review from
ChristophWurst, MorrisJobke, juliusknorr and nickvergessenApril 16, 2019 12:47
ChristophWurst
approved these changes
Apr 16, 2019
kesselb
reviewed
Apr 16, 2019
Uh oh!
There was an error while loading. Please reload this page.
rullzerforce-pushed
the
enh/share_repair_step
branch
from
April 16, 2019 13:41
2b03829 to
093c308CompareSigned-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
rullzer
commented
Apr 17, 2019
MemberAuthor
/backport to stable16 |
rullzer
commented
Apr 17, 2019
MemberAuthor
/backport to stable15 |
rullzer
commented
Apr 17, 2019
MemberAuthor
/backport to stable14 |
nickvergessen
approved these changes
Apr 17, 2019
The backport to stable16 failed. Please do this backport manually. |
The backport to stable15 failed. Please do this backport manually. |
The backport to stable14 failed. Please do this backport manually. |
This was referenced Apr 17, 2019
| if ($notification->getSubject() === 'repair_exposing_links') { | ||
| $notification->setParsedSubject($l->t('Some of your link shares have been removed')); | ||
| $notification->setParsedMessage($l->t('Due to a security bug we had to remove some of your link shares. Please see the link for more information.')); |
Member
There was a problem hiding this comment.
We got the feedback on this one that we in the future should properly communicate the actual removed links/files so that the user has the chance to recreate them manually.
Contributor
Member
There was a problem hiding this comment.
🙈 Too late I would say - for the next time we know it better and can improve on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.