Uh oh!
There was an error while loading. Please reload this page.
Fix multiselect bar overlapping recommendations - #15164
Merged
Merged
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
requested review from
ChristophWurst, MorrisJobke, newhinton and skjnldsvApril 18, 2019 15:41
skjnldsv
approved these changes
Apr 18, 2019
Uh oh!
There was an error while loading. Please reload this page.
jancborchardt
commented
Apr 18, 2019
MemberAuthor
Backport to stable16 at #15166 if needed. |
skjnldsv
commented
Apr 18, 2019
Member
you could have use the backport bot? :) |
jancborchardt
commented
Apr 18, 2019
MemberAuthor
Yeah, I remembered directly after I opened the backport 🤦♂️ :D What’s the syntax again? |
skjnldsv
commented
Apr 18, 2019
Member
/backport to stable16 |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
skjnldsv
previously requested changes
Apr 18, 2019
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Please use @include position('sticky'); then. It will do it automatically :)
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
ChristophWurst
approved these changes
Apr 18, 2019
backport to stable16 in #15198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixnextcloud/recommendations#29 please review @MorrisJobke@ChristophWurst @nextcloud/designers
Before:
After:
And even sticky when scrolling:
