Skip to content

Remove the custom prefix from the table name length when checking on … - #15289

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/15229/fix-non-default-prefixes
Apr 30, 2019
Merged

Remove the custom prefix from the table name length when checking on …#15289
MorrisJobke merged 1 commit into
masterfrom
bugfix/15229/fix-non-default-prefixes

Conversation

@nickvergessen

@nickvergessennickvergessen commented Apr 29, 2019

Copy link
Copy Markdown
Member

…the default primary index

Fix#15229

@nickvergessennickvergessen added this to the Nextcloud 17 milestone Apr 29, 2019
@nickvergessen

nickvergessen commented Apr 29, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

@skjnldsv

skjnldsv commented Apr 30, 2019

Copy link
Copy Markdown
Member

Well, we should probably also check and/or enforce innodb_large_prefix as well as mariadb > 12.2.
Just upgrading mariadb fixed everything for me.

skjnldsv
skjnldsv approved these changes Apr 30, 2019
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But otherwise, fine forme

@nickvergessen

nickvergessen commented Apr 30, 2019

Copy link
Copy Markdown
MemberAuthor

Well, we should probably also check and/or enforce innodb_large_prefix as well as mariadb > 12.2.

That is completely unrelated. But feel free to create a new issue, explain what the problem is and assign it to me.

@skjnldsv

skjnldsv commented Apr 30, 2019

Copy link
Copy Markdown
Member

That is completely unrelated. But feel free to create a new issue, explain what the problem is and assign it to me.

Ah sorry, I thought it was related to the Syntax error or access violation: 1071 Specified key was too long; max key length is 767 bytes

blizzz
blizzz reviewed Apr 30, 2019
View reviewed changes
Comment threadlib/private/DB/MigrationService.php Outdated
@nickvergessen
Remove the custom prefix from the table name length when checking on …
b3e6cbc
…the default primary index
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/15229/fix-non-default-prefixes branch from 01cf3b3 to b3e6cbcCompareApril 30, 2019 10:09
blizzz
blizzz approved these changes Apr 30, 2019
View reviewed changes

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 30, 2019
@MorrisJobke
MorrisJobke merged commit 4907b4e into masterApr 30, 2019
@MorrisJobke
MorrisJobke deleted the bugfix/15229/fix-non-default-prefixes branch April 30, 2019 12:18
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 30, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 30, 2019

Copy link
Copy Markdown

backport to stable16 in #15312

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzzblizzzblizzz approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: install and update

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

Update to 16.0 - InvalidArgumentException: Primary index name on "xxxxxx_collres_collections" is too long.

4 participants

@nickvergessen@skjnldsv@blizzz@MorrisJobke