Skip to content

Fix multiselect min width - #15301

Merged
MorrisJobke merged 1 commit into
masterfrom
fix/select/users-management
May 7, 2019
Merged

Fix multiselect min width#15301
MorrisJobke merged 1 commit into
masterfrom
fix/select/users-management

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Apr 30, 2019

Copy link
Copy Markdown
Member

fix#15246

@nextcloud/designers @j-ed

@skjnldsv
Fix multiselect min width
100b998
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Apr 30, 2019
@skjnldsvskjnldsv added this to the Nextcloud 17 milestone Apr 30, 2019
@skjnldsvskjnldsv self-assigned this Apr 30, 2019
@skjnldsv

skjnldsv commented Apr 30, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

@jancborchardt

jancborchardt commented Apr 30, 2019

Copy link
Copy Markdown
Member

Please check if this fixes your issue @j-ed@mmccarn :)

@j-ed

j-ed commented Apr 30, 2019

Copy link
Copy Markdown
Contributor

The original problem, the missing breadcrumbs behind a record, has been solved but now the whole user list looks a little bit shaky:

grafik

@skjnldsv

skjnldsv commented Apr 30, 2019

Copy link
Copy Markdown
MemberAuthor

@j-ed it should absolutely not look like that.
Could you refresh your cache? :)

@j-ed

j-ed commented Apr 30, 2019

Copy link
Copy Markdown
Contributor

@skjnldsv I've explicitly tested it with a Firefox test profile, where I had deleted all cached data before I logged-into Nextcloud. For you I've repeated the test and got the same result.

@skjnldsv

skjnldsv commented Apr 30, 2019

Copy link
Copy Markdown
MemberAuthor

Even the server css cache? (occ maintenance:repair)
Capture d’écran_2019-04-30_19-10-09

@j-ed

j-ed commented Apr 30, 2019

Copy link
Copy Markdown
Contributor

Sorry, I cannot see any improvement although I've cleared the server cache as you requested.

@MorrisJobke

MorrisJobke commented May 2, 2019

Copy link
Copy Markdown
Member

The original problem, the missing breadcrumbs behind a record, has been solved but now the whole user list looks a little bit shaky:

I can't reproduce this here.

@skjnldsv

skjnldsv commented May 2, 2019

Copy link
Copy Markdown
MemberAuthor

Me neither. I'd say a checkout issue maybe? Or a cache problem again. 🤷‍♀️

@skjnldsv

skjnldsv commented May 7, 2019

Copy link
Copy Markdown
MemberAuthor

Bump

MorrisJobke
MorrisJobke approved these changes May 7, 2019
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works here 👍

@MorrisJobke
MorrisJobke merged commit 8fadc82 into masterMay 7, 2019
@MorrisJobke
MorrisJobke deleted the fix/select/users-management branch May 7, 2019 21:54
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request May 7, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented May 7, 2019

Copy link
Copy Markdown

backport to stable16 in #15433

@ChristophWurstChristophWurst mentioned this pull request May 16, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@kesselbkesselbAwaiting requested review from kesselb
@mmccarnmmccarnAwaiting requested review from mmccarn

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

NC 16 - breadcrumb menu in user management not shown anymore

5 participants

@skjnldsv@jancborchardt@j-ed@MorrisJobke@ChristophWurst