Skip to content

Use css loading animation and not gif - #1535

Merged
juliusknorr merged 1 commit into
masterfrom
files-loading-css-fix
Sep 28, 2016
Merged

Use css loading animation and not gif#1535
juliusknorr merged 1 commit into
masterfrom
files-loading-css-fix

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Good:
kazam_screencast_00004

Bad:
kazam_screencast_00003

@skjnldsvskjnldsv added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files labels Sep 27, 2016
@skjnldsvskjnldsv self-assigned this Sep 27, 2016
@nickvergessen

Copy link
Copy Markdown
Member

You need to commit using commit -s, so it adds your signature:
https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md#sign-your-work

You can also amend the signature manually afterwards:
git commit --amend and then add the line:
Signed-off-by: Random J Developer <random@developer.example.org>

on a new line at the end of your commit message.

@nickvergessen

Copy link
Copy Markdown
Member

👍 for the change

@nickvergessennickvergessen added this to the Nextcloud 11.0 milestone Sep 27, 2016
@nickvergessennickvergessen mentioned this pull request Sep 27, 2016
Signed-off-by: John Molakvoæ <fremulon@protonmail.com>
@juliusknorr

Copy link
Copy Markdown
Member

👍

@juliusknorr
juliusknorr merged commit f219ed2 into masterSep 28, 2016
@juliusknorr
juliusknorr deleted the files-loading-css-fix branch September 28, 2016 08:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsdesignDesign, UI, UX, etc.feature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@nickvergessen@juliusknorr