Uh oh!
There was an error while loading. Please reload this page.
Refactor complex LoginController logic into a login chain of responsibility - #15365
Merged
Conversation
ChristophWurst
marked this pull request as ready for review
May 6, 2019 11:53
ChristophWurstforce-pushed
the
refactor/login-chain
branch
from
May 6, 2019 11:55
f782905 to
17d6864CompareChristophWurstforce-pushed
the
refactor/login-chain
branch
from
May 6, 2019 13:20
17d6864 to
c868ce2CompareChristophWurst
commented
May 7, 2019
MemberAuthor
From what I can tell CI failures do not look related. But tell me if I'm wrong. |
ChristophWurst
commented
May 7, 2019
MemberAuthor
-> restarted |
rullzer
approved these changes
May 7, 2019
rullzer
left a comment
Member
There was a problem hiding this comment.
This is just great. So much cleaner. And tests 🚀
I didn't test in debt but most stuff didn't blow up with my smoke testing.
| } | ||
| public function testNotTwoFactorAuthenticated() { | ||
| $this->fail('todo'); |
MemberAuthor
There was a problem hiding this comment.
guess what … CI fails for a reason
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurstforce-pushed
the
refactor/login-chain
branch
from
May 7, 2019 16:05
c868ce2 to
170582dCompare9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method has been on my list of code to refactor for a long time. As I now have to touch it for https://github.com/orgs/nextcloud/projects/29, I decided to break the code into smaller, maintainable and testable chunks. The code now follows a more strict single responsibility principle, while implementing the chain of responsibility pattern.