Skip to content

[stable15] Handle 0 B default quota properly in the web UI - #15425

Merged
MorrisJobke merged 2 commits into
stable15from
backport/stable15/15359
May 8, 2019
Merged

[stable15] Handle 0 B default quota properly in the web UI#15425
MorrisJobke merged 2 commits into
stable15from
backport/stable15/15359

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented May 7, 2019

Copy link
Copy Markdown
Member

Backport of #15359

@juliusknorr
Fix default quota setting of 0 B
956e545
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Bump user settings bundle
5290686
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorrjuliusknorr added bug 3. to review Waiting for reviews labels May 7, 2019
@juliusknorrjuliusknorr added this to the Nextcloud 15.0.8 milestone May 7, 2019
@juliusknorrjuliusknorr mentioned this pull request May 7, 2019
Merged
@ChristophWurst

ChristophWurst commented May 7, 2019

Copy link
Copy Markdown
Member

Have you run npm i inside settings before building? I have the feeling unrelated webpack bundles got touched.

@ChristophWurst

ChristophWurst commented May 7, 2019

Copy link
Copy Markdown
Member

Bildschirmfoto von 2019-05-07 19-53-24
rebuilding this branch locally gives me these changes

@juliusknorr

juliusknorr commented May 7, 2019

Copy link
Copy Markdown
MemberAuthor

Have you run npm i inside settings before building? I have the feeling unrelated webpack bundles got touched.

npm ci, yes ... let me recheck

@juliusknorr

juliusknorr commented May 7, 2019

Copy link
Copy Markdown
MemberAuthor

@ChristophWurst No, even after a make this is the result 😕

@juliusknorr

juliusknorr commented May 7, 2019

Copy link
Copy Markdown
MemberAuthor

Ok the files are actually not up to date on the stable15 branch:
image

@rullzerrullzer mentioned this pull request May 7, 2019
Merged
@MorrisJobke
MorrisJobke merged commit 585c090 into stable15May 8, 2019
@MorrisJobke
MorrisJobke deleted the backport/stable15/15359 branch May 8, 2019 08:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@georgehrkegeorgehrkeAwaiting requested review from georgehrke

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 15.0.8

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@ChristophWurst@MorrisJobke@skjnldsv