Skip to content

Use non-absolute logout URL to fix wrong URL in reverse proxy scenario - #15430

Merged
rullzer merged 1 commit into
masterfrom
fix/13713/logout-url
May 8, 2019
Merged

Use non-absolute logout URL to fix wrong URL in reverse proxy scenario#15430
rullzer merged 1 commit into
masterfrom
fix/13713/logout-url

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented May 7, 2019

Copy link
Copy Markdown
Member

Fixes#13713

I tested it and it still works. Also the original introduction doesn't give any further details about this: owncloud/core#24056

@MorrisJobkeMorrisJobke added bug 3. to review Waiting for reviews labels May 7, 2019
@MorrisJobkeMorrisJobke added this to the Nextcloud 17 milestone May 7, 2019
@MorrisJobke

MorrisJobke commented May 7, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

@MorrisJobke

MorrisJobke commented May 7, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@MorrisJobkeMorrisJobke mentioned this pull request May 7, 2019
Closed
rullzer
rullzer approved these changes May 8, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the fix. But this does't mean that people with reverse proxies should fix their setup

ChristophWurst
ChristophWurst approved these changes May 8, 2019
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@ChristophWurst

ChristophWurst commented May 8, 2019

Copy link
Copy Markdown
Member

I get the fix. But this does't mean that people with reverse proxies should fix their setup

👍 seconded. I also saw reports for lots of wrongly set up instances behind reverse proxies with U2F and Mail because it's critical there.

Can we check that in the admin settings? As in, comparing the front-end host with an absolute URL from the back-end?

@MorrisJobke

MorrisJobke commented May 8, 2019

Copy link
Copy Markdown
MemberAuthor

Can we check that in the admin settings? As in, comparing the front-end host with an absolute URL from the back-end?

Sure. But let's unify this here. No need to make the URL absolute, because it is always shown within our user interface.

@MorrisJobke

MorrisJobke commented May 8, 2019

Copy link
Copy Markdown
MemberAuthor

Unit tests fail. Let me check them.

@MorrisJobke

MorrisJobke commented May 8, 2019

Copy link
Copy Markdown
MemberAuthor

Unit tests fail. Let me check them.

Done.

@MorrisJobke
MorrisJobkeforce-pushed the fix/13713/logout-url branch from 446052b to 89d4389CompareMay 8, 2019 16:01
@MorrisJobke
Use non-absolute logout URL to fix wrong URL in reverse proxy scenario
f095bd1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
MorrisJobkeforce-pushed the fix/13713/logout-url branch from 89d4389 to f095bd1CompareMay 8, 2019 16:02
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 8, 2019
@rullzer
rullzer merged commit fad3f1a into masterMay 8, 2019
@rullzer
rullzer deleted the fix/13713/logout-url branch May 8, 2019 17:36
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request May 8, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented May 8, 2019

Copy link
Copy Markdown

backport to stable16 in #15452

@backportbot-nextcloud

backportbot-nextcloudBot commented May 8, 2019

Copy link
Copy Markdown

The backport to stable15 failed. Please do this backport manually.

@MorrisJobkeMorrisJobke mentioned this pull request May 8, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@kesselbkesselbAwaiting requested review from kesselb

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

Redirecting bug since 15.0.2

3 participants

@MorrisJobke@ChristophWurst@rullzer