Uh oh!
There was an error while loading. Please reload this page.
Delete calendars with their users - #1545
Merged
Merged
Conversation
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
mention-bot
commented
Sep 27, 2016
@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @icewind1991 and @tcitworld to be potential reviewers |
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
| * @param string $principaluri | ||
| * @return void | ||
| */ | ||
| function deleteAllSharesForUser($principaluri) { |
There was a problem hiding this comment.
For or By? This looks like a trap for the future 🙈
nickvergessen
commented
Sep 28, 2016
Member
Works 👍 |
nickvergessen
commented
Sep 28, 2016
Member
This also was reported yesterday: #1551 I'd like to see a backport to 10 for this. |
LukasReschke
commented
Sep 28, 2016
MemberAuthor
I think that ticket is about contacts, not calendar data. |
nickvergessen
commented
Sep 28, 2016
Member
See the second commit? in this PR? |
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
MorrisJobke
commented
Sep 28, 2016
Member
Tested and works 👍 |
MorrisJobke
approved these changes
Sep 28, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From owncloud/core#25918
Fix#1551