Skip to content

[Stable16] Fix mobile vertical scrolling - #15469

Merged
MorrisJobke merged 1 commit into
stable16from
stb16/fix/mobile/scrolling
May 9, 2019
Merged

[Stable16] Fix mobile vertical scrolling#15469
MorrisJobke merged 1 commit into
stable16from
stb16/fix/mobile/scrolling

Conversation

@skjnldsv

@skjnldsvskjnldsv commented May 9, 2019

Copy link
Copy Markdown
Member

Backport of #15462

@skjnldsvskjnldsv added bug 3. to review Waiting for reviews labels May 9, 2019
@skjnldsvskjnldsv added this to the Nextcloud 16.0.1 milestone May 9, 2019
@skjnldsvskjnldsv self-assigned this May 9, 2019
@skjnldsvskjnldsv mentioned this pull request May 9, 2019
Merged
@skjnldsv
skjnldsv changed the base branch from master to stable16May 9, 2019 10:28
@skjnldsvskjnldsv changed the title Stb16/fix/mobile/scrolling[Stable16] Fix mobile vertical scrollingMay 9, 2019
@skjnldsv

skjnldsv commented May 9, 2019

Copy link
Copy Markdown
MemberAuthor

For some reasons it changed some compiled files in settings 🤷‍♂️

@MorrisJobke

MorrisJobke commented May 9, 2019

Copy link
Copy Markdown
Member

@skjnldsvskjnldsv changed the base branch from master to stable16 2 hours ago

This causes CI to fail :/

@MorrisJobke
MorrisJobkeforce-pushed the stb16/fix/mobile/scrolling branch from 5fe5116 to 3f72d04CompareMay 9, 2019 12:10
rullzer
rullzer approved these changes May 9, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@kesselb

kesselb commented May 9, 2019

Copy link
Copy Markdown
Contributor

Looks like the node_modules are wrong. Try npm ci and build the assets again?

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 9, 2019
@MorrisJobke

MorrisJobke commented May 9, 2019

Copy link
Copy Markdown
Member

Looks like the node_modules are wrong. Try npm ci and build the assets again?

Could also that another PR didn't updated it, or am I wrong here?

@ChristophWurst

ChristophWurst commented May 9, 2019

Copy link
Copy Markdown
Member

For some reasons it changed some compiled files in settings man_shrugging

Do you have node_modules inside settings? If so -> 🔥

@skjnldsv
[Stable16] Fix mobile vertical scrolling
8f56f69
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the stb16/fix/mobile/scrolling branch from 3f72d04 to 8f56f69CompareMay 9, 2019 12:19
@skjnldsv

skjnldsv commented May 9, 2019

Copy link
Copy Markdown
MemberAuthor

Do you have node_modules inside settings? If so ->

That was it! 🎉

@MorrisJobke
MorrisJobke merged commit d4bc8d3 into stable16May 9, 2019
@MorrisJobke
MorrisJobke deleted the stb16/fix/mobile/scrolling branch May 9, 2019 13:23
@MorrisJobkeMorrisJobke mentioned this pull request May 9, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 16.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv@MorrisJobke@kesselb@ChristophWurst@rullzer