Uh oh!
There was an error while loading. Please reload this page.
Check the actual status code for 204 and 304 - #15714
Merged
Merged
Conversation
rullzer
requested review from
ChristophWurst, MorrisJobke, danxuliu, juliusknorr and kesselbMay 24, 2019 11:03
rullzer
commented
May 24, 2019
MemberAuthor
/backport to stable16 |
rullzer
commented
May 24, 2019
MemberAuthor
/backport to stable15 |
This comment has been minimized.
This comment has been minimized.
The header is the full http header like: HTTP/1.1 304 Not Modified So comparing this to an int always yields false This also makes the 304 RFC compliant as the resulting content length should otherwise be the length of the message and not 0. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl> Signed-off-by: Morris Jobke <hey@morrisjobke.de>
| [Http::STATUS_NO_CONTENT], | ||
| [Http::STATUS_NOT_MODIFIED], | ||
| ['HTTP/2.0 204 No content'], | ||
| ['HTTP/2.0 304 Not modified'], |
Member
There was a problem hiding this comment.
The tests where obviously wrong 🙈
backport to stable16 in #15724 |
backport to stable15 in #15725 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header is the full http header like: HTTP/1.1 304 Not Modified
So comparing this to an int always yields false
This also makes the 304 RFC compliant as the resulting content length
should otherwise be the length of the message and not 0.