Skip to content

dont use part files for dav writes when the target folder doesn't have create permissions - #15769

Merged
MorrisJobke merged 2 commits into
masterfrom
part-file-non-creatable
Jul 3, 2019
Merged

dont use part files for dav writes when the target folder doesn't have create permissions#15769
MorrisJobke merged 2 commits into
masterfrom
part-file-non-creatable

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991icewind1991 added the 3. to review Waiting for reviews label May 28, 2019
@icewind1991icewind1991 added this to the Nextcloud 17 milestone May 28, 2019
@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@skjnldsv

Copy link
Copy Markdown
Member

@icewind1991 is there an existing issue this pr fixes? :)
Code looks good to me!

@icewind1991

Copy link
Copy Markdown
MemberAuthor

This issue came from a customer originally, I've added a test case for the issue

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Make sense!

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke

Copy link
Copy Markdown
Member

PHPUnit tests for comments failed. Thus I rebased this to fetch potential fixes.

…e create permissions
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@MorrisJobke
MorrisJobkeforce-pushed the part-file-non-creatable branch from 2cbd040 to 3b6df74CompareJuly 3, 2019 14:36
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 3, 2019
@MorrisJobke
MorrisJobke merged commit 18b673e into masterJul 3, 2019
@delete-merged-branch
delete-merged-branchBot deleted the part-file-non-creatable branch July 3, 2019 21:30
@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable16 in #16223

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #16224

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@skjnldsv@MorrisJobke