Uh oh!
There was an error while loading. Please reload this page.
Show share settings only if incoming federated shares are allowed - #15830
Merged
Conversation
Fixes#15802 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
ChristophWurst, juliusknorr, rullzer and schiessleMay 31, 2019 15:41
MorrisJobke
commented
May 31, 2019
MemberAuthor
/backport to stable16 |
MorrisJobke
commented
May 31, 2019
MemberAuthor
/backport to stable15 |
schiessle
approved these changes
May 31, 2019
schiessle
left a comment
Member
There was a problem hiding this comment.
tested and works as expected! 👍
ChristophWurst
approved these changes
Jun 3, 2019
backport to stable16 in #15926 |
The backport to stable15 failed. Please do this backport manually. |
skjnldsv
commented
Jun 11, 2019
Member
15 backport #15927 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#15802
Followup to #15638 which implemented like it was before, but that had a logical bug in it to only show the ID when outgoing federated shares where allowed, but it makes only sense to show the federated ID for incoming federated shares.
And it removes unneeded code.