Skip to content

Update Encryption.php - #15946

Merged
rullzer merged 4 commits into
nextcloud:masterfrom
martink-p:bugxfix/9792/encrypted-external-webdav
Aug 15, 2019
Merged

Update Encryption.php#15946
rullzer merged 4 commits into
nextcloud:masterfrom
martink-p:bugxfix/9792/encrypted-external-webdav

Conversation

@martink-p

@martink-pmartink-p commented Jun 13, 2019•
edited by kesselb
Loading

Copy link
Copy Markdown
Contributor

Fix#9792
Pull request for a working solution of issue #9792 (#9792)

@martink-pmartink-p mentioned this pull request Jun 13, 2019
Closed
kesselb
kesselb reviewed Jun 13, 2019
View reviewed changes
Comment threadlib/private/Files/Stream/Encryption.php Outdated
kesselb
kesselb reviewed Jun 13, 2019
View reviewed changes
Comment threadlib/private/Files/Stream/Encryption.php Outdated
kesselb
kesselb reviewed Jun 13, 2019
View reviewed changes
Comment threadlib/private/Files/Stream/Encryption.php Outdated
kesselb
kesselb reviewed Jun 13, 2019
View reviewed changes
Comment threadlib/private/Files/Stream/Encryption.php Outdated
kesselb
kesselb reviewed Jun 13, 2019
View reviewed changes
Comment threadlib/private/Files/Stream/Encryption.php Outdated
kesselb
kesselb reviewed Jun 13, 2019
View reviewed changes
Comment threadlib/private/Files/Stream/Encryption.php Outdated
@kesselbkesselb added 3. to review Waiting for reviews bug labels Jun 13, 2019
@kesselbkesselb added this to the Nextcloud 17 milestone Jun 13, 2019
@kesselb

kesselb commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

Ref owncloud/core#34599 and owncloud/core#35519 for some more details

martink-pand others added 4 commits June 17, 2019 12:13
@martink-p
Update Encryption.php
4b9675d
Signed-off-by: martink-p <47943787+martink-p@users.noreply.github.com>
@martink-p@kesselb
Apply suggestions from code review
39a4fe4
Co-Authored-By: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: martink-p <47943787+martink-p@users.noreply.github.com>
@martink-p
Update Encryption.php
8b22ede
Signed-off-by: martink-p <47943787+martink-p@users.noreply.github.com>
@martink-p
Update Encryption.php
9cff71f
Signed-off-by: martink-p <47943787+martink-p@users.noreply.github.com>
@martink-p
martink-pforce-pushed the bugxfix/9792/encrypted-external-webdav branch from 04ad7ed to 9cff71fCompareJune 17, 2019 10:14
@MorrisJobkeMorrisJobke mentioned this pull request Jul 15, 2019
Merged
28 tasks
schiessle
schiessle approved these changes Aug 15, 2019
View reviewed changes

@schiessleschiessle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martink-p thanks for your pull request! Looks good to me and makes absolutely sense.

@rullzer
rullzer merged commit d14aed1 into nextcloud:masterAug 15, 2019
@welcome

welcomeBot commented Aug 15, 2019

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@kesselbkesselb mentioned this pull request Aug 28, 2019
Closed
@kesselbkesselb mentioned this pull request Oct 1, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb left review comments
@rullzerrullzerrullzer approved these changes
@schiessleschiessleschiessle approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

Encrypted external WebDAV storage not working in NC 13.0.3, OCP\Encryption\Exceptions\GenericEncryptionException: Missing Signature

4 participants

@martink-p@kesselb@rullzer@schiessle