Uh oh!
There was an error while loading. Please reload this page.
cache the displayname after an LDAP plugin set it - #15987
Merged
Conversation
blizzz
requested review from
ChristophWurst, juliusknorr, skjnldsv and viniciuscbJune 17, 2019 22:22
skjnldsv
approved these changes
Jun 18, 2019
This comment has been minimized.
This comment has been minimized.
4 tasks
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzzforce-pushed
the
fix/noid/cache-displayname-on-save
branch
from
June 18, 2019 10:42
0ef97fd to
a1f2dbeComparejuliusknorr
approved these changes
Jun 18, 2019
blizzz
commented
Jun 18, 2019
MemberAuthor
/backport to stable16 |
blizzz
commented
Jun 18, 2019
MemberAuthor
/backport to stable15 |
backport to stable16 in #16000 |
backport to stable15 in #16001 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you have an LDAP plugin that would write the displayname, in the current state the cache would not be updated. Thus, a refresh will still show the old name, this is confusing. That's solved now.