Uh oh!
There was an error while loading. Please reload this page.
Properly load permissions in showActions - #15992
Merged
Merged
Conversation
skjnldsv
approved these changes
Jun 18, 2019
juliusknorr
commented
Jun 18, 2019
MemberAuthor
/backport to stable16 |
juliusknorr
commented
Jun 18, 2019
MemberAuthor
/backport to stable15 |
ChristophWurst
approved these changes
Jun 19, 2019
skjnldsv
commented
Jun 19, 2019
Member
Jsunit fails --------------3193|undefined3194|TypeError: undefinedisnotanobject(evaluating'fileList.setFiles')inapps/files/tests/js/filelistSpec.js(line3460)3195|apps/files/tests/js/filelistSpec.js:3460:123196|TypeError: undefinedisnotanobject(evaluating'fileList.showFileBusyState')inapps/files/tests/js/filelistSpec.js(line3464)3197|apps/files/tests/js/filelistSpec.js:3464:123198|TypeError: undefinedisnotanobject(evaluating'notificationStub.restore')inapps/files/tests/js/filelistSpec.js(line187)3199|apps/files/tests/js/filelistSpec.js:187:193200|PhantomJS2.1.1(Linux0.0.0)OCA.Files.FileListtestsshowFileBusyStateacceptsmultipleinputformatsFAILED3201|TypeError: Attemptedtowrapredirectwhichisalreadywrappedinbuild/lib/node_modules/sinon/pkg/sinon.js(line3901)3202|undefined3203 |
When setViewerMode(false) is called, the permissions should be fetched from the available dirInfo Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorrforce-pushed
the
bugfix/noid/showActions-permission
branch
from
July 5, 2019 10:21
75091b2 to
51683faComparejuliusknorr
commented
Jul 5, 2019
MemberAuthor
Ok, jsunit tests should be fine now. |
backport to stable16 in #16282 |
backport to stable15 in #16283 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setViewerMode(false) is called, the permissions should be fetched from the available dirInfo, otherwise creating a file is not possible.
Fixes#16238
Steps to reproduce: