Uh oh!
There was an error while loading. Please reload this page.
(LDAP) API: return one base properly when multiple are configured - #16011
Merged
Conversation
* reading the config directly will return the value with line breaks * using the proper accessor gives us all bases in an array * returns the first matching one * having user id provided for the group base is strange and does not let us operate like this. here we return the first one. might change in future, a backportable fix won't have an API change however. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* the backend already expects and works with the string Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
ChristophWurst, juliusknorr, rullzer, skjnldsv and viniciuscbJune 19, 2019 11:43
4 tasks
skjnldsv
approved these changes
Jun 19, 2019
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Much cleaner!
Code looks good to me.
Though tests will tell ;)
blizzz
commented
Jun 19, 2019
MemberAuthor
/backport to stable16 |
blizzz
commented
Jun 19, 2019
MemberAuthor
/backport to stable15 |
ChristophWurst
approved these changes
Jun 19, 2019
backport to stable16 in #16015 |
The backport to stable15 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
us operate like this. here we return the first one. might change in
future, a backportable fix won't have an API change however.