Skip to content

Forward OCSException to initiator - #16024

Merged
rullzer merged 1 commit into
masterfrom
bugfix/15944/fix-return-code-user-provision
Jun 25, 2019
Merged

Forward OCSException to initiator#16024
rullzer merged 1 commit into
masterfrom
bugfix/15944/fix-return-code-user-provision

Conversation

@kesselb

@kesselbkesselb commented Jun 20, 2019

Copy link
Copy Markdown
Contributor

Fix#15944

Before this patch

<?xml version="1.0"?>
<ocs>
<meta>
<status>failure</status>
<statuscode>101</statuscode>
<message>Bad request</message>
<totalitems></totalitems>
<itemsperpage></itemsperpage>
</meta>
<data/>
</ocs>

After this patch

<?xml version="1.0"?>
<ocs>
<meta>
<statuscode>109</statuscode>
<message>Unable to send the invitation mail</message>
<totalitems></totalitems>
<itemsperpage></itemsperpage>
</meta>
<data/>
</ocs>

@kesselb
Forward OCSException to initiator
4177653
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselb requested a review from skjnldsvJune 20, 2019 17:12
@kesselbkesselb added 3. to review Waiting for reviews bug labels Jun 20, 2019
@kesselbkesselb added this to the Nextcloud 17 milestone Jun 20, 2019
skjnldsv
skjnldsv approved these changes Jun 21, 2019
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense!

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 21, 2019
@skjnldsv

skjnldsv commented Jun 21, 2019

Copy link
Copy Markdown
Member

Tests restarted, too many unknwown failures

@kesselb

kesselb commented Jun 21, 2019

Copy link
Copy Markdown
ContributorAuthor

Tests restarted, too many unknwown failures

🤞

@rullzer
rullzer merged commit 98244b5 into masterJun 25, 2019
@rullzer
rullzer deleted the bugfix/15944/fix-return-code-user-provision branch June 25, 2019 11:32
@MorrisJobke

MorrisJobke commented Jul 2, 2019

Copy link
Copy Markdown
Member

@kesselb@rullzer@ChristophWurst Backport to which branches?

@kesselb

kesselb commented Jul 2, 2019

Copy link
Copy Markdown
ContributorAuthor

/backport to stable16

@kesselb

kesselb commented Jul 2, 2019

Copy link
Copy Markdown
ContributorAuthor

/backport to stable15

@kesselb

kesselb commented Jul 2, 2019

Copy link
Copy Markdown
ContributorAuthor

/backport to stable14

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 2, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 2, 2019

Copy link
Copy Markdown

backport to stable16 in #16191

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 2, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 2, 2019

Copy link
Copy Markdown

backport to stable15 in #16192

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 2, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 2, 2019

Copy link
Copy Markdown

backport to stable14 in #16193

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@georgehrkegeorgehrkeAwaiting requested review from georgehrke
@blizzzblizzzAwaiting requested review from blizzz

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

User provisioning API response - wrong status code

6 participants

@kesselb@skjnldsv@MorrisJobke@nickvergessen@ChristophWurst@rullzer