Uh oh!
There was an error while loading. Please reload this page.
fix LDAP Wizard forgetting groups on select with search - #16033
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
ChristophWurst, danxuliu, georgehrke, juliusknorr and skjnldsvJune 21, 2019 13:06
ChristophWurst
commented
Jun 21, 2019
Member
We should consider integrating https://github.com/kelseyhightower/nocode for even less code. |
blizzz
commented
Jun 21, 2019
MemberAuthor
The contribution policy is sort of not very welcoming though 🤔 at least it also does not require a CLA. |
skjnldsv
approved these changes
Jun 22, 2019
skjnldsv
commented
Jun 22, 2019
Member
|
blizzz
commented
Jun 24, 2019
MemberAuthor
was a timeout in CI, run through now |
blizzz
commented
Jun 24, 2019
MemberAuthor
/backport to stable16 |
blizzz
commented
Jun 24, 2019
MemberAuthor
/backport to stable15 |
backport to stable16 in #16051 |
backport to stable15 in #16052 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you have more than 40 groups, the LDAP wizard shows a different group selection utility to better cope with long lists. It can be searched too. Sadly, when a filtered selection was done and added, the previously selected groups were forgotten. See following recordings
The bug:
https://cloud.nextcloud.com/s/555t9EkAe9j9G2y
(You also notice that the left box is not properly populated again)
And resolved:
https://cloud.nextcloud.com/s/aKXxZHwdybypBN9
What I love about the fix is that it works much better with less LOCs :)