Uh oh!
There was an error while loading. Please reload this page.
Fix placement of icon in public share page for audio files - #16118
Merged
rullzer merged 2 commits intoJun 27, 2019
Conversation
The preview element in the public share page was always wrapped with a link to download the file; now that link is included only if the "Hide download" option of the share is not enabled. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When the preview for audio files is used an HTML 5 audio element is shown in the public share page. This element is added by the template, so it is already there when the mimetype icon is added to the "#imgframe" element. Instead of appended the icon is now prepended, so it appears before the audio element (prepending instead of appending should make no difference for other types of files, as in that case the "#imgframe" element is empty). Besides that, the CSS was modified to show the icon centered above the audio preview instead of next to it. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
requested review from
ChristophWurst, jancborchardt, rullzer and skjnldsvJune 27, 2019 12:02
skjnldsv
approved these changes
Jun 27, 2019
jancborchardt
approved these changes
Jun 27, 2019
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Nice! Not sure if we need backport, I would leave it.
77 tasks
delete-merged-branchBot
deleted the
fix-placement-of-icon-in-public-share-page-for-audio-files
branch
June 27, 2019 14:28
danxuliu
commented
Jul 1, 2019
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test
Before:
After:
Is this worth a backport? If yes, up to which version?