Make possible to focus grid/list view toggle via keyboard

[jancborchardt]

Needs help from @nextcloud/javascript to actually make the toggle also work on pressing enter when focused. :)

[jancborchardt]

Needs help from @nextcloud/javascript to actually make the toggle also work on pressing enter when focused. :)

[skjnldsv]

Hum, actually I think this is the wrong way to go.
The label should not receive the focus on keyboard nav.
The checkbox should. That way you don't loose the element indicator on screen readers and you get the default behaviour everywhere :)

[jancborchardt]

@skjnldsv tried giving the checkbox the tab focus, but it seems to conflict with our custom checkboxes. What would your approach be?

[skjnldsv]

tried giving the checkbox the tab focus

But the checkbox should already have the focus, right? Since this is a hidden and not display:none element?
If you're talking about the focus visual feedback of the label, then I guess there is a css issue? 🤔

[jancborchardt]

tried giving the checkbox the tab focus

But the checkbox should already have the focus, right? Since this is a hidden and not display:none element?
If you're talking about the focus visual feedback of the label, then I guess there is a css issue? thinking

Please test. :) It does not receive the focus at all at the moment.

[skjnldsv]

Nice catch!
This needs to be removed indeed:

server/apps/files/css/files.scss

Lines 1084 to 1086 in b6376b7

	#showgridview {
	display: none;
	}

[rullzer]

So 17 or 18?

[jancborchardt]

I would say 17 since it fixes the accessibility of an essential part of the software. As said, needs JS help. @skjnldsv?

[skjnldsv]

As said, needs JS help

No, only what is mentioned on my comment.
Nothing related to js here :)

[skjnldsv]

Here, can you review @jancborchardt :)

[jancborchardt]

Nice, this works! :)

The only thing is that the toggle is focused before the home and upload icons in the controls bar? This seems strange and it should rather be between the upload button and the Recommendations.

Otherwise 👍

[skjnldsv]

The only thing is that the toggle is focused before the home and upload icons in the controls bar? This seems strange and it should rather be between the upload button and the Recommendations.

then we should move the input and label after the home button (in the html order)

[rullzer]

Lets fix that separatly so this at least is in

[skjnldsv]

/backport to stable16

[backportbot-nextcloud]

backport to stable16 in #16745