Skip to content

Fix usage view tests - #16198

Merged
MorrisJobke merged 1 commit into
masterfrom
fix/tests/usage
Jul 2, 2019
Merged

Fix usage view tests#16198
MorrisJobke merged 1 commit into
masterfrom
fix/tests/usage

Conversation

@rullzer

@rullzerrullzer commented Jul 2, 2019

Copy link
Copy Markdown
Member

Follow up to #16049
Should fix CI

@rullzer
Fix usage view tests
7da7acd
Follow up to #16049
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added bug 3. to review Waiting for reviews labels Jul 2, 2019
@rullzerrullzer added this to the Nextcloud 17 milestone Jul 2, 2019
skjnldsv
skjnldsv approved these changes Jul 2, 2019
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed it

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 2, 2019
@MorrisJobkeMorrisJobke mentioned this pull request Jul 2, 2019
Merged
@kesselb

kesselb commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

Thanks 👍

I was asked to display 158,8mb as 159mb but humanFileSize always returns 158,8mb. I think we should revert the line below because 123 b is not 100 kb and fix it properly later.

$nav->assign('usage', \OC_Helper::humanFileSize(ceil($storageInfo['used'] / 102400) * 102400));

@MorrisJobke
MorrisJobke merged commit 63c64bf into masterJul 2, 2019
@MorrisJobke
MorrisJobke deleted the fix/tests/usage branch July 2, 2019 17:22
@rullzer

rullzer commented Jul 2, 2019

Copy link
Copy Markdown
MemberAuthor

@kesselb makes sense. feel free to do that :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

5 participants

@rullzer@kesselb@MorrisJobke@ChristophWurst@skjnldsv