Uh oh!
There was an error while loading. Please reload this page.
Revert incorrect rouding - #16200
Merged
Merged
Conversation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
This reverts commit 7da7acd Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
| $nav->assign('navigationItems', $navItems); | ||
| $nav->assign('usage', \OC_Helper::humanFileSize(ceil($storageInfo['used'] / 102400) * 102400)); | ||
| $nav->assign('usage', \OC_Helper::humanFileSize($storageInfo['used'])); |
Member
There was a problem hiding this comment.
Can't we do this on 102400 and bigger and keep the old way on smaller values?
skjnldsv
approved these changes
Jul 2, 2019
MorrisJobke
commented
Jul 3, 2019
Member
Let's do this now and tackle my comment afterwards 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the mess 🙈
103 b are not 100 kb. The way introduced by #16049 only works for mb.
cc @jancborchardt we need to do 158,8mb => 159mb later 😞