Uh oh!
There was an error while loading. Please reload this page.
Always set the display name for user shares - #16208
Merged
Merged
Conversation
juliusknorr
requested review from
ChristophWurst, MorrisJobke, kesselb and rullzerJuly 3, 2019 09:36
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorrforce-pushed
the
bugfix/noid/user-share-displayname
branch
from
July 3, 2019 19:34
2a981a7 to
857fae2CompareChristophWurst
approved these changes
Jul 4, 2019
juliusknorr
commented
Jul 5, 2019
MemberAuthor
/backport to stable16 |
rullzer
approved these changes
Jul 5, 2019
backport to stable16 in #16254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sharing recommentations use the shareWithDisplayname of the Share object, so we need to make sure the displayname is always set there.
Otherwise the uid is always shown for the sharing recommendations instead of the displayname.