Uh oh!
There was an error while loading. Please reload this page.
Sidebar sections integration - #16312
Closed
juliusknorr wants to merge 3 commits into
Closed
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv
reviewed
Jul 9, 2019
| <div :is="section($refs['section-'+$index], fileInfo)" :file-info="fileInfo"></div> | ||
| </div> | ||
| <collection-list v-if="fileInfo" type="file" :id="`${fileInfo.id}`" :name="fileInfo.name"></collection-list> |
MemberAuthor
There was a problem hiding this comment.
Yes, the id of a project resource is of type string, so we need to cast.
juliusknorr
commented
Jul 9, 2019
MemberAuthor
@skjnldsv I leave bumping the nextcloud-vue-collections to 0.5.4 up to you if thats fine, so we have a bit less rebasing work here. |
skjnldsvforce-pushed
the
enhancement/sidebar/standard
branch
3 times, most recently
from
July 12, 2019 19:00
7b7239c to
87480c0CompareMorrisJobke
commented
Jul 15, 2019
Member
@juliushaertl What is the status here? We are close to the beta 1. Should this go into 17 or 18? |
juliusknorr
commented
Jul 16, 2019
MemberAuthor
18 since this is part of #15719 |
skjnldsvforce-pushed
the
enhancement/sidebar/standard
branch
4 times, most recently
from
July 28, 2019 08:53
9cf8980 to
e45019fCompareskjnldsvforce-pushed
the
enhancement/sidebar/standard
branch
from
August 8, 2019 17:22
3bcc7b6 to
4241a55Compareskjnldsvforce-pushed
the
enhancement/sidebar/standard
branch
from
September 9, 2019 08:58
866e069 to
f27f965Compareskjnldsvforce-pushed
the
enhancement/sidebar/standard
branch
from
September 16, 2019 19:04
00ff19d to
cc1a2c9Compare25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires a new build of nextcloud-vue-collections