Uh oh!
There was an error while loading. Please reload this page.
Set proper web title for apple - #1644
Merged
Merged
Conversation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
mention-bot
commented
Oct 7, 2016
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @jancborchardt and @LukasReschke to be potential reviewers. |
codecov-io
commented
Oct 7, 2016
Current coverage is 56.57% (diff: 100%)@@ master #1644 diff @@
==========================================
Files 1070 1070 Lines 60497 61172 +675 Methods 6829 6945 +116 Messages 0 0 Branches 0 0 ==========================================
+ Hits 34014 34610 +596 - Misses 26483 26562 +79
Partials 0 0
|
MorrisJobke
commented
Oct 7, 2016
Member
👍 |
MorrisJobke
approved these changes
Oct 7, 2016
Member
👎 we should use the instance name from OC_Defaults/ThemingDefaults here: |
MorrisJobke
commented
Oct 7, 2016
Member
You are right - I just forgot about that. |
nickvergessen
commented
Oct 7, 2016
Member
Updated |
juliusknorr
commented
Oct 7, 2016
Member
👍 |
MorrisJobke
commented
Oct 7, 2016
Member
Tested and works 👍 |
jancborchardt
commented
Oct 7, 2016
Member
@rullzer@nickvergessen should be backported to the stable branches as important name change, right? cc @karlitschek |
karlitschek
commented
Oct 7, 2016
Member
Should be low risk. Please backport! 👍 |
MorrisJobke
commented
Oct 11, 2016
Member
Let me backport this |
This was referenced Oct 11, 2016
MorrisJobke
commented
Oct 11, 2016
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easy one: @LukasReschke@nickvergessen@MorrisJobke