Skip to content

allow to provide supported calendar component set internally as a string - #16503

Merged
rullzer merged 1 commit into
masterfrom
bugfix/5504/create_new_birthday_calendars_with_VEVENT_only
Jul 25, 2019
Merged

allow to provide supported calendar component set internally as a string#16503
rullzer merged 1 commit into
masterfrom
bugfix/5504/create_new_birthday_calendars_with_VEVENT_only

Conversation

@georgehrke

Copy link
Copy Markdown
Member

To test:

  • delete your contact's birthday calendar
  • run php occ dav:sync-birthday-calendar
  • check components row in database

On master it's VEVENT,VTODO
(the default value from

'components' => 'VEVENT,VTODO',
)

On this branch it's VEVENT
(as intended in

'components' => 'VEVENT',
)

fixes#5504

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrkegeorgehrke added the 3. to review Waiting for reviews label Jul 22, 2019
@georgehrke

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

@georgehrke

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@georgehrkegeorgehrke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 25, 2019
@rullzer
rullzer merged commit c504ed6 into masterJul 25, 2019
@delete-merged-branch
delete-merged-branchBot deleted the bugfix/5504/create_new_birthday_calendars_with_VEVENT_only branch July 25, 2019 11:36
@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable16 in #16536

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #16537

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Contacts Birthdays' showing up as task list

4 participants

@georgehrke@tcitworld@skjnldsv@rullzer