Modify do_action so default ctrl-click opens tab

[KnownNexus]

Modify do_action to use an ID number
Use item in do_action instead of currentFile
Limit launching direct actions to one time
Use full file item instead of attr-only

Implements #16067

[juliusknorr]

Nice, seems to work quite well. I've commented inline, but here are some general minor issues with the code style:

• Indentation should use tabs not spaces
• Variable names should be camel case triedActionOnce
• Please remove the console.log statements (they seem to be leftovers from debugging)

[KnownNexus]

I'm not sure what is causing the CI to fail, could someone help me figure it out?
Also i don't believe i have permission to restart the tests, is it possible restarting them could allow them to pass?

[davepage-mcr]

Hi @juliushaertl can you please re-run the CI for this MR or help @KnownNexus understand why it is failing?

[kesselb]

can you please re-run the CI for this MR

Just rebase this branch to get the latest changes from master and run ci again

[kesselb]

https://github.com/nextcloud/server/blob/master/apps/files/tests/js/favoritesfilelistspec.js

This test is failing. CI uses https://github.com/nextcloud/server/blob/master/autotest-js.sh to run the jsunit tests. I guess you need node and some dependencies to run these locally. autotest-js.sh works fine for me on ubuntu.

LOG: 'nextPage...'
LOG: 'Launching editor, params=undefined'
LOG: 'openAction: no action found'
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FavoritesFileList tests loading file list render files FAILED
Expected 'http://localhost/index.php/apps/files?dir=/somedir&editfile=7' to equal 'http://localhost/remote.php/webdav/somedir/test.txt'.
apps/files/tests/js/favoritesfilelistspec.js:92:51
....
LOG: 'nextPage...'
LOG: 'Launching editor, params=undefined'
LOG: 'openAction: no action found'
LOG: 'openAction: no action found'
PhantomJS 2.1.1 (Linux 0.0.0) ERROR
{
"message": "Some of your tests did a full page reload!",
"str": "Some of your tests did a full page reload!"
}
PhantomJS 2.1.1 (Linux 0.0.0): Executed 506 of 1073 (1 FAILED) (skipped 4) ERROR (2.349 secs / 2.286 secs)
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FavoritesPlugin tests file actions redirects to files app when opening a directory FAILED
Expected '/' to equal '/somewhere/inside/subdir/testdir'.
apps/files/tests/js/favoritespluginspec.js:120:64
Expected false to equal true.
apps/files/tests/js/favoritespluginspec.js:122:48
Expected false to equal true.
apps/files/tests/js/favoritespluginspec.js:123:57

[KnownNexus]

@kesselb
Hi,
I've looked into the errors and had a look at the framework.
It looks like, since i'm opening a new tab with the new functionality, the test is reaching that point, and seeing the new tab as a "page refresh" which causes the tests to break.

As i understand it, the existing framework does not support refreshing the tab or opening new ones mid way through the tests.

Do you have any ideas on how i can bypass this?

[kesselb]

Hi @KnownNexus, sorry for late reply 🙈 Could you rebase the branch with the latest master?

Probably @juliushaertl or @skjnldsv know how to fix the tests.

[jonathanmaw]

Hi @kesselb,

I'm @KnownNexus 's coworker. He's moved on to other things so I'm looking after this for him.

I'll have a look at these changes and see if I can understand these changes and take responsibility for them.

[azul]

Hi @KnownNexus@jonathanmaw ,

Any progress on this? I have rebased your branch and fixed the indentation to only use tabs.
The branch is here:
https://github.com/azul/server/tree/open-new_tab

I'll look into the failing tests next. Please let me know if you are still working on this so we do not duplicate efforts.

[jonathanmaw]

Hi Azul,

thanks for taking care of this. I would be very grateful for you to look into the tests, since I have lost access to the equipment I had previously used to work on this due to the coronavirus restrictions.

[juliusknorr]

Merged with #20185